Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to support screenshots / images below sub directories #28

Merged
merged 3 commits into from
Sep 9, 2023

Conversation

gforcada
Copy link
Member

@gforcada gforcada commented Jun 29, 2023

Big disclaimer: code, as seen on the commits is from @datakurre , I'm merely creating the PR on his behalf 😅

TODO:

  • decide which python and robotframework version ranges we want to support
  • is it compatible with both selenium and playwright based tests?

Part of plone/Products.CMFPlone#3813

Only test on supported python versions (3.8+) and versions of robotframework that work on those python versions
@mauritsvanrees
Copy link
Member

The Plone coredev buildout 6.0 has been using a checkout of this branch for a long time, and the robot tests seem fine. So can we get this merged and released please?

I do see that the GitHub-actions in this repo need fixing. They fail with:

Action failed with error: Error: Unable to locate executable file: cachix. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.

I suppose it is fine to keep this package in the coredev checkouts for a bit longer, and not have a new robotsuite version in the upcoming Plone 6.0.7.

@datakurre datakurre merged commit c2f7ac4 into master Sep 9, 2023
16 checks passed
@datakurre
Copy link
Contributor

I don't remove the branch to not break coredev too soon.

@datakurre
Copy link
Contributor

Released robotsuite==2.3.2

Thanks for the heads up!

@mauritsvanrees
Copy link
Member

Thanks. I have updated coredev 6.0 and 6.1 to use the new release, so I will remove this branch.

@mauritsvanrees mauritsvanrees deleted the datakurre-rfbrowser branch September 11, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants