Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to set types for all id columns #432

Closed

Conversation

vassilevsky
Copy link

Hello :)

Thank you for the wonderful gem!

We use UUID for all id columns and this is something that we would need.

Let me know if anything else is needed.

@fatkodima
Copy link
Contributor

fatkodima commented Apr 3, 2018

I don't think this is that hard to do it manually, after migration was generated, to complicate things.
So I'm 👎 on this.

@vassilevsky
Copy link
Author

Yep, it's really easy to edit the generated migration. Do you think all options can be removed then?

@fatkodima
Copy link
Contributor

Yes, I think so. I have proposed that here #430 (comment)
but has not yet received any feedback.

@josephpage
Copy link

I think it should be completely removed, but it should use the default column type from Rails.
The one which can be configured with

config.generators do |g|
  g.orm :active_record, primary_key_type: :uuid
end

I can work on it in my PR #433

@vassilevsky
Copy link
Author

I have created #434 that completely removes options instead :)

@vassilevsky vassilevsky closed this Apr 4, 2018
@vassilevsky vassilevsky deleted the configure-all-id-columns branch April 4, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants