-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds redacted option #485
Adds redacted option #485
Conversation
* In order to record that changes occurred, without storing sensitive values, pass the `redacted` option. * Redacted values default to `'[REDACTED]'` but can be customized with the `redaction_value` option. ``` class User audited redacted: [:password, :ssn], redaction_value: SecureRandom.uuid end ``` * A lot of this was based on the work done [here](collectiveidea#339). * Resolves collectiveidea#475.
eb53b24
to
c200bb5
Compare
Hi – is there anything we can do / help with to move this PR forward? Thanks. |
Hello again – is there anything we can do to move this along? |
Hey @jits, I don't think there's anything to be done on my end, it's a matter of the maintainers having the availability to review this. I'm sure they are very busy! I see that you have a particular use case that this is needed for - I wonder if it's possible to apply a monkey patch to an initializer file for this gem to cover that case. Or, if you were really desperate, you could always fork the gem itself and apply this patch. Although I realize that it not at all ideal, as it'll make future updates harder to work with. Just some ideas! |
@JonathanWThom – thanks for this really useful PR! And appreciate your suggestions – I'll look into a local monkey patch, or a fork, for now. I recognise that the maintainers are likely very busy – if they do see this, please let us know if there's anything we can do to help get this released. |
Thanks for merging @danielmorrison! |
Stay up to date with the original gem, including support for Rails 6.1 that was added since the fork. From the changelog: Added - Add redacted option [collectiveidea#485](collectiveidea#485) - Rails 6.1. support [collectiveidea#554](collectiveidea#554) [collectiveidea#559](collectiveidea#559) Improved - Avoid extra query on first audit version [collectiveidea#513](collectiveidea#513)
In order to record that changes occurred, without storing sensitive
values, pass the
redacted
option.Redacted values default to
'[REDACTED]'
but can be customized withthe
redaction_value
option.A lot of this was based on the work done here.
Resolves [Idea] Filter option #475.