Support and test Rails 6.0 #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add correct DB adapter gems to each version to avoid gem activation errors, but ensure the main gemspec can match all permitted versions. Fixes collectiveidea#488
Soft-deprecated since Rails 4.0 but in Rails 6.0 it now prints a deprecation warning, so switch it out for `update!` (preferring the bang version to pick up on any errors).
The adapter only defaults to utf8mb4 on newer MySQL versions, else requires a specific charset under Rails 6.0 for our version.
No support for 2.6 (or HEAD) on Rails 4.2, exclude it.
|
The CI build statuses seem to be missing (one for @danielmorrison, might need to try reinstalling the Travis CI integration), but the PR builds are running. Here's the link: https://travis-ci.org/collectiveidea/audited/builds/529345653 |
|
@domcleal I reinstalled the integration. Not sure it will show up on this PR, but I think it should on future ones… |
danielmorrison
approved these changes
May 7, 2019
|
@danielmorrison thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes Ruby 2.6 in the test matrix, fixes a deprecation and a couple of small issues that prevented tests running correctly on Rails 6.0.
Fixes #488