Make lock_nodes_between use #450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 6c5040c Rails warnings were fixed. It changed the implementation of `lock_nodes_between` from: instance_base_class. ... to the following: instance_base_class.default_scoped. ... To check if these implementations are similar we can add a check to `lock_nodes_between`. If we add the following line to `lock_nodes_between` we can compare the resulting SQL for both implementations: raise if instance_base_class.default_scoped.right_of(left_bound).left_of_right_side(right_bound).to_sql != instance_base_class.right_of(left_bound).left_of_right_side(right_bound).to_sql Adding this check makes a spec fail. Changing the check to use `unscoped` instead doesn't makes the specs fail. So changing the implementation to only use `unscoped` makes sure the resulting SQL is similar to how it was before 6c5040c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 6c5040c Rails warnings were fixed.
It changed the implementation of
lock_nodes_betweenfrom:to the following:
To check if these implementations are similar we can add a check to
lock_nodes_between. If we add the following line tolock_nodes_betweenwe can compare the resulting SQL for bothimplementations:
Adding this check makes a spec fail.
Changing the check to use
unscopedinstead doesn't makes thespecs fail.
So changing the implementation to only use
unscopedmakes surethe resulting SQL is similar to how it was before
6c5040c.