Add ruby 2.2 and 2.3 to travis build #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artofhuman
force-pushed
the
master
branch
3 times, most recently
from
5a3b0cd to
cc1a804
Compare
|
/cc @laserlemon |
laserlemon
reviewed
Feb 7, 2017
Gemfile
Outdated
| @@ -5,4 +5,5 @@ gemspec | |||
| group :test do | |||
| gem "codeclimate-test-reporter", require: false | |||
| gem "rspec", "~> 3.1" | |||
| gem "json", "< 2.0.0" if RUBY_VERSION < '2' | |||
There was a problem hiding this comment.
Is this necessary to green the suite? Was Ruby 1.9.3 failing prior to this?
There was a problem hiding this comment.
now it not neccessary ruby/json@3015920
laserlemon
reviewed
Feb 7, 2017
.travis.yml
Outdated
| @@ -18,5 +18,7 @@ rvm: | |||
| - 1.9.3 | |||
| - "2.0" | |||
| - "2.1" | |||
| - "2.2" | |||
| - "2.3" | |||
There was a problem hiding this comment.
Is there any reason not to include Ruby 2.4 now as well?
There was a problem hiding this comment.
Ugh, it failed on 2.4 because RVM doesn't seem to want to fuzzy match. We may have to be more specific for 2.4.
artofhuman
force-pushed
the
master
branch
4 times, most recently
from
6471297 to
b632369
Compare
|
🍏 |
|
Thank you! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.