Update the README testing example to one that works #80
Conversation
The example of how to testing Interactors in the README does not work in the current version of `interactor`. This is a huge barrier to entry for anyone looking to use the library. We should update the README to indicate how tests should actually be done. Note: This commit is just intended to add the spec to show that it fails. I will add a second commit in a moment to show the method that I use to test my Interactors.
|
Hopefully this PR is structured in a way that makes sense. I can add another commit that removes Thanks for making such a fun interactor library. I'm really enjoying it compared to the previous library I used and am liking some of the discussion for the future of the gem. |
|
I was running into the same difficulty just now, looking at the tests in the README. I think you can also modify the test in the README to replace calls of |
|
Hmm, fair enough. I liked the |
|
Looks good :) @posgarou the .run should not be used, its an internal method and may change in every update. |
| }.to change { | ||
| context.message | ||
| }.from(nil).to be_present | ||
| expect(subject.message).to_not be_present |
There was a problem hiding this comment.
If I'm reading this correctly the original expectation is that the messages goes from nil to being set after the subject has been invoked. The new expectation asserts that message isn't set after the subject has been invoked. That doesn't line up with the name of the test or what it is replacing.
There was a problem hiding this comment.
Ah yes, that's a typo. Thank you for pointing it out! If you look at the test at spec/readme_spec.rb:47 I actually have it correct. I'll change that right away.
|
I merged #84 with an updated readme because it applied cleanly. Thank you for your help! |
The example of how to testing Interactors in the README does not work in
the current version of
interactor. This is a huge barrier to entry foranyone looking to use the library. We should update the README to
indicate how tests should actually be done.
Note: This commit is just intended to add the spec to show that it
fails. I will add a second commit in a moment to show the method that
I use to test my Interactors.