Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI, add Python 3.10 #109

Merged
merged 31 commits into from
Feb 12, 2023
Merged

Fix CI, add Python 3.10 #109

merged 31 commits into from
Feb 12, 2023

Conversation

johnnynunez
Copy link
Contributor

@johnnynunez johnnynunez commented Feb 2, 2023

  • Python 3.6 & 3.7 deleted
  • Python 3.10 & 3.11 added
  • Flann is required
  • Maintain macOS 11 only.
  • Pybind11 compatible with Python 3.11

@sarlinpe
Copy link
Collaborator

sarlinpe commented Feb 2, 2023

Thanks for looking into this. I'm getting too many notifications so muting this PR for now - give us a heads up once it is ready for a full review.

@johnnynunez
Copy link
Contributor Author

Thanks for looking into this. I'm getting too many notifications so muting this PR for now - give us a heads up once it is ready for a full review.

oh sorry so much, I didn't know that!

.github/workflows/build-new.yml Outdated Show resolved Hide resolved
.github/workflows/build-new.yml Outdated Show resolved Hide resolved
.github/workflows/build-new.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
package/build-wheels-linux-new.sh Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@johnnynunez
Copy link
Contributor Author

@skydes First of all, apologies for the commits and notifications. It's difficult to work only with act.
For my part it work done, I think. I hope it will be the final one.

@johnnynunez
Copy link
Contributor Author

@skydes How is it going?

@mihaidusmanu
Copy link
Collaborator

Looks good to me overall. Let's wait for Paul to take a look when he has a moment too. We will merge some other PRs that were stuck due to broken CI and then bump up version to 0.5 too.

@sarlinpe sarlinpe changed the title python 3.10 and 3.11 Fix CI, add Python 3.10 Feb 12, 2023
@sarlinpe
Copy link
Collaborator

Let's delay the pybind upgrade because we'd need to simultaneously upgrade it in pyceres and pixsfm as well. This forces us to push back Python 3.11 support (though I don't think this is a big deal for now).

@sarlinpe sarlinpe self-requested a review February 12, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants