-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI, add Python 3.10 #109
Conversation
johnnynunez
commented
Feb 2, 2023
•
edited
Loading
edited
- Python 3.6 & 3.7 deleted
- Python 3.10 & 3.11 added
- Flann is required
- Maintain macOS 11 only.
- Pybind11 compatible with Python 3.11
Thanks for looking into this. I'm getting too many notifications so muting this PR for now - give us a heads up once it is ready for a full review. |
oh sorry so much, I didn't know that! |
@skydes How is it going? |
Looks good to me overall. Let's wait for Paul to take a look when he has a moment too. We will merge some other PRs that were stuck due to broken CI and then bump up version to 0.5 too. |
Let's delay the pybind upgrade because we'd need to simultaneously upgrade it in pyceres and pixsfm as well. This forces us to push back Python 3.11 support (though I don't think this is a big deal for now). |