Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pickling of objects #243

Merged
merged 7 commits into from
Jan 23, 2024
Merged

Enable pickling of objects #243

merged 7 commits into from
Jan 23, 2024

Conversation

sarlinpe
Copy link
Collaborator

@sarlinpe sarlinpe commented Jan 22, 2024 •
edited
Loading

  • Copy bindings are moved to MakeDataclass
  • All dataclass objects become pickleable
  • To enable this, todict() now only exports data attributes
  • This requires the following breaking changes:
    • Rotation3d.quat becomes a property
    • {Rigid3d,Sim3d}.matrix becomes a function
    • Image.num_points2D becomes a function
  • for Camera this would remove useful attributes from the summary (like param_info) so we explicitly pass the list of data attributes

Base automatically changed from sarlinpe/fix-bug-summary to master January 23, 2024 19:42
@sarlinpe sarlinpe merged commit 6f0096d into master Jan 23, 2024
5 of 6 checks passed
@sarlinpe sarlinpe deleted the sarlinpe/pickling branch January 23, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phil26AT Phil26AT Phil26AT approved these changes

@mihaidusmanu mihaidusmanu Awaiting requested review from mihaidusmanu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarlinpe @Phil26AT