-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce cross-file dependencies with forward declarations #1862
Open
lolbot-iichan
wants to merge
15
commits into
colobot:dev
Choose a base branch
from
lolbot-iichan:dev-forward-declarations
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reduce cross-file dependencies with forward declarations #1862
lolbot-iichan
wants to merge
15
commits into
colobot:dev
from
lolbot-iichan:dev-forward-declarations
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93a4e61
to
c4e904c
Compare
c4e904c
to
a64b9af
Compare
tomaszkax86
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that editing some headers forces rebuilding almost whole project. This makes hard to make any refactoring.
Tested this theory by running
gcc -MM -MG
for cpp files and found out that there are 8300+ header imports for 200 cpp files.Current PR suggest some quick changes that helps reduce the number of imports by 15% by using forward declarations.
Please, review commit-by-commit, not file-by-file.
There are many files changed, but almast all the changes are:
enum SomeType: unsigned char
Other then that there are a few changes:
CScoreboard::SortType
that was a member of a class to enum classScoreboardSortType
, so that it would be possible to use forward declarationStartTaskPen
arg to avoid using enum element in header.struct WheelTrace
, since they are always initialized in cpp file anyway, to avoid using enum element in header.Top 20 header import before this PR:
Top 20 header import after this PR: