-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiply languages #27
Conversation
Cannot really reproduce the travis error, everything looks fine on my machine:
|
I think it's better to attach the files and send it to you , because I have
|
@khaledalhasan I think you can't add files to github comments via email. |
thanks for the PR @sangyye @khaledalhasan how about introducing arabic together at the next meeting? The next meeting will be Thursday next week (March 3rd). Will you be able to come? If yes, it would be nice if you could fill out the Doodle here http://doodle.com/poll/vspxtbxfvfxwpdtg |
Yes , of course I'll be there , I filled out the doodle also .
|
I removed the |
I have no idea why this gives an error. Everything fine on my end and on the online-validator. |
@sangyye since we have no checked in Gemfile.lock, Travis might be installing different versions of our dependencies. Consider comparing the versions, and I don't think there is any reason not to check in the Gemfile.lock for this project. |
@jhilden Okay, I added it, but I already checked the versions, and it seems that there are no difference in the versions. |
@jhilden Even with the added Gemfile.lock it errors on travis and works fine on my local computer. Can't really understand that... |
<link rel="stylesheet" type="text/css" href="stylesheets/stylesheet.css" media="screen"> | ||
<link rel="stylesheet" type="text/css" href="stylesheets/github-light.css" media="screen"> | ||
<link rel="stylesheet" type="text/css" href="stylesheets/print.css" media="print"> | ||
<link rel="stylesheet" type="text/css" href="{{ site.github.url }}/stylesheets/stylesheet.css" media="screen"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this necessary? are relative paths not working here anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, because I use redirects on subfolders with the language, you need absolute paths for the stylesheets. Otherway the index in the folder doesn't find the sheets.
I added support for more languages than english, so it's easy to add other languages. The detection works via the default language in the browser. If this is not detected or the language is not translated, it defaults to english.
Limitations:
TODO: