Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiply languages #27

Merged
merged 13 commits into from
Apr 25, 2016
Merged

Conversation

sangyye
Copy link
Member

@sangyye sangyye commented Feb 23, 2016

I added support for more languages than english, so it's easy to add other languages. The detection works via the default language in the browser. If this is not detected or the language is not translated, it defaults to english.

Limitations:

  • The language chooser only works within the root of the domain, no folders are supported. (but the Stylesheets work)

TODO:

  • Add a language chooser

@sangyye
Copy link
Member Author

sangyye commented Feb 23, 2016

Cannot really reproduce the travis error, everything looks fine on my machine:

$ bundle exec htmlproof --check-html --disable-external ./_site
Running ["ImageCheck", "ScriptCheck", "HtmlCheck", "LinkCheck"] on ./_site on *.html...


Ran on 2 files!


HTML-Proofer finished successfully.
$ bundle exec htmlproof -v
htmlproof 2.6.4

@devcops-xyz
Copy link

I think it's better to attach the files and send it to you , because I have
no experience
On 23 Feb 2016 12:18 pm, "Christian Vervoorts" notifications@github.com
wrote:

Cannot really reproduce the travis error, everything looks fine on my
machine:

$ bundle exec htmlproof --check-html --disable-external ./_site
Running ["ImageCheck", "ScriptCheck", "HtmlCheck", "LinkCheck"] on ./_site on *.html...

Ran on 2 files!

HTML-Proofer finished successfully.
$ bundle exec htmlproof -v
htmlproof 2.6.4


Reply to this email directly or view it on GitHub
#27 (comment).

@sangyye
Copy link
Member Author

sangyye commented Feb 23, 2016

@khaledalhasan I think you can't add files to github comments via email.

@jhilden
Copy link
Member

jhilden commented Feb 23, 2016

thanks for the PR @sangyye

@khaledalhasan how about introducing arabic together at the next meeting? The next meeting will be Thursday next week (March 3rd). Will you be able to come? If yes, it would be nice if you could fill out the Doodle here http://doodle.com/poll/vspxtbxfvfxwpdtg

@devcops-xyz
Copy link

Yes , of course I'll be there , I filled out the doodle also .
On 23 Feb 2016 2:25 pm, "Jakob Hilden" notifications@github.com wrote:

thanks for the PR @sangyye https://github.com/sangyye

@khaledalhasan https://github.com/khaledalhasan how about introducing
arabic together at the next meeting? The next meeting will be Thursday next
week (March 3rd). Will you be able to come? If yes, it would be nice if you
could fill out the Doodle here http://doodle.com/poll/vspxtbxfvfxwpdtg


Reply to this email directly or view it on GitHub
#27 (comment).

@sangyye
Copy link
Member Author

sangyye commented Feb 23, 2016

I removed the --check-html until I know why I get the strange error in travis but not on my local machine

@sangyye
Copy link
Member Author

sangyye commented Feb 23, 2016

I have no idea why this gives an error. Everything fine on my end and on the online-validator.

@jhilden
Copy link
Member

jhilden commented Feb 24, 2016

@sangyye since we have no checked in Gemfile.lock, Travis might be installing different versions of our dependencies. Consider comparing the versions, and I don't think there is any reason not to check in the Gemfile.lock for this project.

@sangyye
Copy link
Member Author

sangyye commented Feb 24, 2016

@jhilden Okay, I added it, but I already checked the versions, and it seems that there are no difference in the versions.

@sangyye
Copy link
Member Author

sangyye commented Feb 24, 2016

@jhilden Even with the added Gemfile.lock it errors on travis and works fine on my local computer. Can't really understand that...

<link rel="stylesheet" type="text/css" href="stylesheets/stylesheet.css" media="screen">
<link rel="stylesheet" type="text/css" href="stylesheets/github-light.css" media="screen">
<link rel="stylesheet" type="text/css" href="stylesheets/print.css" media="print">
<link rel="stylesheet" type="text/css" href="{{ site.github.url }}/stylesheets/stylesheet.css" media="screen">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this necessary? are relative paths not working here anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, because I use redirects on subfolders with the language, you need absolute paths for the stylesheets. Otherway the index in the folder doesn't find the sheets.

@sangyye sangyye merged commit 609ad1d into colognerb:gh-pages Apr 25, 2016
@sangyye sangyye mentioned this pull request Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants