feat: use expected type for Connection::__construct() to bypass phpst…

…an errors (#255)
colopl · Jan 7, 2025 · fd45164 · fd45164
1 parent afbf238
commit fd45164
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -7,8 +7,6 @@ parameters:
         - '#^Return type \(void\) of method .*? should be compatible with return type \(.*?\) of method .*?$#'
         - message: '#^Method Colopl\\Spanner\\Connection::runPartitionedDml\(\) should return int but returns mixed\.$#'
           path: src/Concerns/ManagesPartitionedDml.php
-        - message: '#^Parameter \#1 \$pdo of method Illuminate\\Database\\Connection::__construct\(\) expects Closure|PDO, null given\.$#'
-          path: src/Connection.php
         - message: '#^Method Colopl\\Spanner\\Connection::selectWithOptions\(\) should return array<int, array> but returns mixed\.$#'
           path: src/Connection.php
         - message: "#^Return type \\(Generator\\<int, array, mixed, mixed\\>\\) of method Colopl\\\\Spanner\\\\Connection\\:\\:cursor\\(\\) should be compatible with return type \\(Generator\\<int, stdClass, mixed, mixed\\>\\) of method Illuminate\\\\Database\\\\Connection\\:\\:cursor\\(\\)$#"

diff --git a/src/Connection.php b/src/Connection.php
@@ -108,7 +108,13 @@ public function __construct(
         $this->instanceId = $instanceId;
         $this->authCache = $authCache;
         $this->sessionPool = $sessionPool;
-        parent::__construct(null, $database, $tablePrefix, $config);
+        parent::__construct(
+            // TODO: throw error after v9
+            static fn() => null,
+            $database,
+            $tablePrefix,
+            $config,
+        );
     }
 
     /**