Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: explicitly stage transaction to correctly run afterCommit jobs #144

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix: explicitly stage transaction to correctly run afterCommit jobs #144

merged 1 commit into from
Nov 17, 2023

Conversation

oprudkyi
Copy link
Contributor

@oprudkyi oprudkyi commented Nov 16, 2023 •
edited
Loading

Laravel v10.32.0 requires explicit staging/clearing of transactions laravel/framework#48859
without this code afterCommit jobs are never sent

Fix: #

Checklist

  • CHANGELOG

Reference

@taka-oyama taka-oyama self-assigned this Nov 17, 2023
@taka-oyama taka-oyama self-requested a review November 17, 2023 00:30
@taka-oyama taka-oyama assigned oprudkyi and unassigned taka-oyama Nov 17, 2023
@taka-oyama taka-oyama added bug Something isn't working dependencies Pull requests that update a dependency file labels Nov 17, 2023
@taka-oyama taka-oyama added this to the 6.0 milestone Nov 17, 2023
@taka-oyama
Copy link
Collaborator

taka-oyama commented Nov 17, 2023 •
edited
Loading

Hi, thank you for submitting the fix.

May I ask you to do the following.

  • Add the fix to CHANGELOG
  • Change the composer.json dependency for laravel/framework from ^10.0 to ^10.32.0.

Thanks!

@taka-oyama taka-oyama modified the milestones: 6.0, 5.2 Nov 17, 2023
@taka-oyama
Copy link
Collaborator

[Note to self] This needs to be back ported to v5 and be released as v5.3.0

@oprudkyi
fix: explicitly stage/clear transaction to correctly run afterCommit …
d71c0bc 
…jobs

laravel v10.32.0 requires explicit staging of transactions
laravel/framework#48859
@oprudkyi
Copy link
Contributor Author

Hi @taka-oyama

done. please check

@taka-oyama taka-oyama merged commit 1a043a8 into colopl:master Nov 17, 2023
taka-oyama pushed a commit that referenced this pull request Nov 17, 2023
@oprudkyi @taka-oyama
fix: explicitly stage/clear transaction to correctly run afterCommit …
eeb504d 
…jobs (#144)

laravel v10.32.0 requires explicit staging of transactions
laravel/framework#48859
# Conflicts:
#	CHANGELOG.md
@taka-oyama
Copy link
Collaborator

Thanks for the PR. This has been released as v5.3.0.

This was referenced Jun 18, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taka-oyama taka-oyama taka-oyama approved these changes

Assignees

@oprudkyi oprudkyi

Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@oprudkyi @taka-oyama