Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ZTS detection #26

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Fix ZTS detection #26

merged 3 commits into from
Nov 27, 2024

Conversation

zeriyoshi
Copy link
Collaborator

PHP_ZTS is now bool

@zeriyoshi zeriyoshi self-assigned this Nov 25, 2024
This was referenced Nov 25, 2024
Merged
Merged
@zeriyoshi
Copy link
Collaborator Author

blocking: #28

@zeriyoshi zeriyoshi changed the title Fix ZTS detection in PHPUnit Fix ZTS detection Nov 25, 2024
t-matsuno-777
t-matsuno-777 approved these changes Nov 27, 2024
View reviewed changes
Copy link

@t-matsuno-777 t-matsuno-777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@zeriyoshi zeriyoshi merged commit ecd939b into colopl:main Nov 27, 2024
50 of 51 checks passed
@zeriyoshi zeriyoshi deleted the fix_phpunit_tests branch November 27, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-matsuno-777 t-matsuno-777 t-matsuno-777 approved these changes

Assignees

@zeriyoshi zeriyoshi

Labels
waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeriyoshi @t-matsuno-777