Merge pull request #85 from facelessuser/bugfix/deltae-2000

Fix error in Delta E algorithm
color-js · Apr 3, 2021 · 13135c9 · 13135c9
2 parents ccb846e + ce1b802
commit 13135c9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/deltaE/deltaE2000.js b/src/deltaE/deltaE2000.js
@@ -84,7 +84,7 @@ Color.prototype.deltaE2000 = function (sample, {kL = 1, kC = 1, kH = 1} = {}) {
 	let habs = Math.abs(hdiff);
 	let Δh;
 
-	if (Cdash1 == 0 && Cdash2 == 0) {
+	if (Cdash1 * Cdash2 === 0) {
 		Δh = 0;
 	}
 	else if (habs <= 180) {
@@ -112,7 +112,7 @@ Color.prototype.deltaE2000 = function (sample, {kL = 1, kC = 1, kH = 1} = {}) {
 	// Four possibilities for hue weighting factor,
 	// depending on the angles, to get the correct sign
 	let hdash;
-	if (Cdash1 == 0 && Cdash2 == 0) {
+	if (Cdash1 * Cdash2 === 0) {
 		hdash = hsum;   // which should be zero
 	}
 	else if (habs <= 180) {