Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name collision in /fn #171

Closed
sgomes opened this issue Jun 29, 2022 · 1 comment
Closed

Name collision in /fn #171

sgomes opened this issue Jun 29, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@sgomes
Copy link
Collaborator

sgomes commented Jun 29, 2022

Looks like chromaticity.js and interpolation.js both have an export named register. This becomes a problem because they both get re-exported with * from index-fn.js:

export *                      from "./luminance.js";
export *                      from "./chromaticity.js";

Sample webpack error:

ERROR in ./node_modules/colorjs.io/src/index-fn.js 20:0-55
The requested module './chromaticity.js' contains conflicting star exports for the name 'register' with the previous requested module './luminance.js'
 @ ./src/index.js 1:0-52

ERROR in ./node_modules/colorjs.io/src/index-fn.js 24:0-56
The requested module './interpolation.js' contains conflicting star exports for the name 'register' with the previous requested module './luminance.js'
 @ ./src/index.js 1:0-52
@LeaVerou LeaVerou added the bug Something isn't working label Jun 29, 2022
@LeaVerou
Copy link
Member

Fixed with #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants