Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index-fn reexport collisions #172

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

sgomes
Copy link
Collaborator

@sgomes sgomes commented Jun 29, 2022

This PR renames some re-exports in index-fn.js, so that there are no name collisions.

See #171.

@LeaVerou
Copy link
Member

Thank you so much! I don't think we need these exports at all, the whole point of index-fn is to be tree-shakeable and register() is used to add these methods to the Color object (see how it's used in index.js). So I think we can just remove these exports, do you agree?

@LeaVerou LeaVerou closed this Jun 29, 2022
@LeaVerou LeaVerou reopened this Jun 29, 2022
@LeaVerou
Copy link
Member

Oops, didn't mean to close this, sorry! (puzzled how Cmd + enter did that)

@sgomes
Copy link
Collaborator Author

sgomes commented Jun 29, 2022

So I think we can just remove these exports, do you agree?

@LeaVerou Yes, that sounds good! Done 🙂

@LeaVerou LeaVerou merged commit 121f162 into color-js:main Jun 29, 2022
@LeaVerou
Copy link
Member

Thank you! Will release a v.0.2.4 ASAP

@sgomes
Copy link
Collaborator Author

sgomes commented Jun 29, 2022

@LeaVerou Thank you! 🙏 You may want to take a look at #169 as well before you do so, however, as it would be good to roll that fix into the new version as well.

@LeaVerou
Copy link
Member

LeaVerou commented Jun 29, 2022

Thanks, just did so! I guess I'll wait an hour or so in case other low hanging fruit emerges

@LeaVerou
Copy link
Member

Actually scratch that, if people are playing with it, we shouldn't have a broken package. I've merged all open PRs and will release now.

@LeaVerou LeaVerou mentioned this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants