-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Our rec2100-hlg is wrong #190
Comments
You might want to add a note to the JSON that generates our color space docs. |
Note added in f1fa0ed |
Now fixed and gives the results expected from ITU-R BT.2390-10 page 25:
|
The scaling factor assumes an overall system gamma of 1, and should be a default which is adjustable for different viewing conditions. For now, it is correct for standard viewing conditions. |
I see from the convert app that the results for rec2100-hlg are very wrong.
I thought I knew how to fix it, looking at BT.2390, but I tried it and I don't.
(Note that BT.2390 expects the linear-light intensity range Edash to be 0 to 1 over the HDR range, while our code puts 0-1 over the SDR range so media white is at 1. Even accounting for that, I still couldn't fix it).
It seems from this email that things are more complex than I thought.
Explorations meanwhile are in a separate repo and I want to get some expert review from BBC folks before that comes back to color.js.
In particular there will probably need to be an options object with
to cope with non-reference monitor and non-reference ambient illumination.
Meanwhile here be dragons and don't use our rec2100-hlg for anything important.
The text was updated successfully, but these errors were encountered: