Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[types] Add type definitions from DefinitelyTyped/DefinitelyTyped#62510 #221

Merged
merged 5 commits into from
Oct 13, 2022
Merged

[types] Add type definitions from DefinitelyTyped/DefinitelyTyped#62510 #221

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5afc0f3
[types] Add type definitions from DefinitelyTyped/DefinitelyTyped#62510
MysteryBlokHed Oct 2, 2022
936e9af
[types] Fix problems highlighted by dtslint
MysteryBlokHed Oct 5, 2022
ef28db5
Fix dtslint (#1)
jgerigmeyer Oct 11, 2022
89d1da2
Initial round of types review (#2)
jgerigmeyer Oct 11, 2022
138d5f1
[types] Add types for space accessors
MysteryBlokHed Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
{
"parser": "babel-eslint",
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 6,
"sourceType": "module",
"ecmaFeatures": {
"impliedStrict": true
}
},
"plugins": [
"classPrivateMethods"
],
"env": {
"browser": true,
"node": true
Expand Down
16 changes: 16 additions & 0 deletions .github/workflows/test-types.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Test Type Definitions
on: pull_request

jobs:
test:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: "12"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't 12 a bit old at this point?

Copy link
Member Author

@MysteryBlokHed MysteryBlokHed Oct 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I chose 12 because the Babel config specifies version <=12, but it could be made more recent



- run: npm install
- run: npm run dtslint
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
dist/
/dist/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the leading slash means that Git will only ignore the dist folder in the root of the project. Without this change, the folder types/dist is also ignored

node_modules/

# Ignore generated HTML files
Expand Down
Loading