Fix bundler compatibility #239
Conversation
|
I'm fine to make the change, though I think it's a bug in these tools if they mess up |
|
I've checked all prototype properties, there're only two properties that got renamed:
|
|
@jgerigmeyer what do you think? Fine to merge if it LGTY. |
|
Looks good on a quick skim, but I'd be happy to take a closer look tomorrow. 👍🏻 |
There was a problem hiding this comment.
@ambar Looks good! Thanks for this contribution. 🚀
One minor request, then this is ready to merge.
ambar
force-pushed
the
fix-bundler-compatibility
branch
from
5234d41 to
38438d8
Compare
|
Thanks for the fix! Can we get a release which includes this? |
colorjs.io is currently incompatible with bundlers. See color-js/color.js#239 Remove this postinstall script once we upgrade to a version which includes that PR.
|
Will try to do that tomorrow! |
|
Ping: We would still be happy about a release including this fix. Thanks for your efforts! |
|
Done! Sorry I dropped the ball last week. |
…#721) #### What type of PR is this? /kind feature /milestone 2.0.0-rc.2 #### What this PR does / why we need it: 添加自动计算文章标签文字颜色的支持。在之前的版本中，因为引入 colorjs.io 导致在构建之后无法显示标签，目前 colorjs.io 已经修复此问题，此 PR 回归之前的支持。 - https://github.com/LeaVerou/color.js/releases/tag/v0.4.2 - color-js/color.js#239 #### Special notes for your reviewer: 测试方式： 1. 创建若干文章标签，设置不同的背景色，观察文字颜色是否会自动与背景颜色形成反差。 2. 使用 `pnpm build` 构建生产版本，在 Halo 的配置文件中配置 `halo.console.location` 到 Console 的 `dist` 目录。 3. 检查 Console 文章列表中的标签是否显示正常。 #### Does this PR introduce a user-facing change? ```release-note Console 端添加自动计算文章标签文字颜色的支持。 ```
…halo-dev/console#721) #### What type of PR is this? /kind feature /milestone 2.0.0-rc.2 #### What this PR does / why we need it: 添加自动计算文章标签文字颜色的支持。在之前的版本中，因为引入 colorjs.io 导致在构建之后无法显示标签，目前 colorjs.io 已经修复此问题，此 PR 回归之前的支持。 - https://github.com/LeaVerou/color.js/releases/tag/v0.4.2 - color-js/color.js#239 #### Special notes for your reviewer: 测试方式： 1. 创建若干文章标签，设置不同的背景色，观察文字颜色是否会自动与背景颜色形成反差。 2. 使用 `pnpm build` 构建生产版本，在 Halo 的配置文件中配置 `halo.console.location` 到 Console 的 `dist` 目录。 3. 检查 Console 文章列表中的标签是否显示正常。 #### Does this PR introduce a user-facing change? ```release-note Console 端添加自动计算文章标签文字颜色的支持。 ```
Fixes #235
It's not safe to access function name in bundled apps, such as (reproduced in):
This bug could also reproduced in
dist/color.global.min.js(main branch, bundled by terser):