Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[types] Update Coords type to allow null #530

Merged
merged 1 commit into from
May 28, 2024
Merged

[types] Update Coords type to allow null #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/src/color.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import {

export type { SpaceAccessor } from "./space-coord-accessors.js";

export type Coords = [number, number, number];
export type Coords = [number | null, number | null, number | null];

export interface ColorObject {
spaceId?: string | ColorSpace | undefined;
Expand Down
4 changes: 3 additions & 1 deletion types/test/color.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Color from "colorjs.io/src/color";
import Color, { Coords } from "colorjs.io/src/color";

// @ts-expect-error
new Color();
Expand All @@ -19,4 +19,6 @@ color.clone(); // $ExpectType Color
color.display();
color.display({ space: "srgb" });

const coords: Coords = [1, 2, null];

// Most other color methods are those defined in other files, so they aren't tested here
Loading