Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HSV to HSL conversion #68

Merged
merged 1 commit into from
Jan 30, 2021
Merged

Conversation

facelessuser
Copy link
Collaborator

Do not scale lightness back to 0 - 100 until conversions are done.

Before fix:

>  new Color("color(hsv 60 50 40)").to('srgb').to('hsv').toString()
'color(hsv 60.001 2.021 30.306)'

After fix:

>  new Color("color(hsv 60 50 40)").to('srgb').to('hsv').toString()
'color(hsv 60 50 40)'

Do not scale lightness back to 0 - 100 until conversions are done
@LeaVerou LeaVerou merged commit 5d30a44 into color-js:master Jan 30, 2021
@LeaVerou
Copy link
Member

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants