Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in Delta E algorithm #85

Merged
merged 3 commits into from
Apr 3, 2021
Merged

Fix error in Delta E algorithm #85

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9190a22
Fix error in Delta E algorithm
facelessuser Mar 30, 2021
74aff44
Use triple equal
facelessuser Mar 31, 2021
ce1b802
Revert abs compare
facelessuser Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/deltaE/deltaE2000.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ Color.prototype.deltaE2000 = function (sample, {kL = 1, kC = 1, kH = 1} = {}) {
let habs = Math.abs(hdiff);
let Δh;

if (Cdash1 == 0 && Cdash2 == 0) {
if (Cdash1 * Cdash2 === 0) {
Δh = 0;
}
else if (habs <= 180) {
Expand Down Expand Up @@ -112,7 +112,7 @@ Color.prototype.deltaE2000 = function (sample, {kL = 1, kC = 1, kH = 1} = {}) {
// Four possibilities for hue weighting factor,
// depending on the angles, to get the correct sign
let hdash;
if (Cdash1 == 0 && Cdash2 == 0) {
if (Cdash1 * Cdash2 === 0) {
hdash = hsum; // which should be zero
}
else if (habs <= 180) {
Expand Down