Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor non-content fixes in color-difference.md #88

Merged
merged 3 commits into from
Jun 17, 2021

Conversation

micgro42
Copy link
Contributor

I noticed a typo and stray comment in color-difference.md and my IDE also noticed an unmatched bracket 🙂

This comment was part of the import example code in the previous code
block and probably copied here by accident.
@micgro42
Copy link
Contributor Author

Also, it would seem that the two colors in the code block where the comment was removed are supposed to be different, but they are the same.
From the intro-text to that code block, it would seem that they are supposed to differ by ca. 2.3, but since all three algorithms produce different results, I'm hesitant to suggest a color here myself.

@LeaVerou LeaVerou merged commit ba14578 into color-js:master Jun 17, 2021
@LeaVerou
Copy link
Member

Thanks for spotting that!

@svgeesus What's up with the example?

@micgro42 micgro42 deleted the docsTypoFixes branch June 18, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants