-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace lazy_static
with once_cell
#119
base: master
Are you sure you want to change the base?
Conversation
744b5dd
to
1921f20
Compare
Could you merge this repo's |
That would create useless merge commits polluting the history. The correct operation would be to rebase onto current master. Just FYI. |
I was planning on doing a squash merge once the PR got in anyway @LingMan, so it shouldn't matter much. |
Ah, I see. The squash button does still add the title of the merge commit to the commit message, but it is an improvement over leaving them separate. |
Done. |
@@ -1,5 +1,6 @@ | |||
//! A couple of functions to enable and disable coloring. | |||
|
|||
use once_cell::sync::Lazy; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming the other crates used in the library have extern crate
definitions in the root because of an old Rust version that's being targeted, but I'll have to double check once the crate gets an MSRV figured out (see #85).
This would technically be a breaking change, and I'd probably end up putting this inside a v3 of colored
, which is already planned if #139 ends up happening. I'll probably end up making a v2
branch or something, and then I can get this merged in.
Could this been done with https://doc.rust-lang.org/std/sync/struct.Once.html ? |
No description provided.