Fix various warnings and issues #79
Conversation
|
Might be worth adding |
| @@ -96,7 +96,7 @@ impl Style { | |||
| /// assert_eq!(colored.style().contains(Styles::Italic), true); | |||
| /// assert_eq!(colored.style().contains(Styles::Dimmed), false); | |||
| /// ``` | |||
| pub fn contains(&self, style: Styles) -> bool { | |||
| pub fn contains(self, style: Styles) -> bool { | |||
There was a problem hiding this comment.
are you sure about this change ? I don't think that consuming the style for a query is wise
There was a problem hiding this comment.
I was also confused by this initially, but according to rust this is actually more efficient because the size of passing around Style is smaller than the size of passing around a reference to it:
take a look at this output:
warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
--> src/style.rs:99:21
|
99 | pub fn contains(&self, style: Styles) -> bool {
| ^^^^^ help: consider passing by value instead: `self`
|
= note: `#[warn(clippy::trivially_copy_pass_by_ref)]` on by default
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
I guess the point is that because this enum hs the Copy trait, its cheaper to copy and pass the value then it is to pass around a reference to the original.
take a look here for details: https://rust-lang.github.io/rust-clippy/master/#trivially_copy_pass_by_ref
| @@ -321,7 +321,7 @@ impl ColoredString { | |||
| /// assert_eq!(cstr.bgcolor(), None); | |||
| /// ``` | |||
| pub fn bgcolor(&self) -> Option<Color> { | |||
| self.bgcolor.as_ref().map(|x| *x) | |||
| self.bgcolor.as_ref().copied() | |||
| @@ -284,6 +281,7 @@ mod tests { | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
|
Yes, I think adding a clippy test to the CI would be a great idea ! |
I'll add it in tonight :) |
MichaelAquilina
force-pushed
the
chore/clippy_fixes
branch
5 times, most recently
from
c0d4169
to
4a03efc
Compare
|
Added clippy to Travis in 4a03efc. I've also enabled caching on travis for faster build times |
MichaelAquilina
force-pushed
the
chore/clippy_fixes
branch
from
4a03efc
to
09f13d1
Compare
MichaelAquilina
force-pushed
the
chore/clippy_fixes
branch
from
09f13d1
to
7390472
Compare
|
@mackwic any chance this could get reviewed / merged when you have the time? |
|
Thank you for the ping ! It's all good ! :D Thank you for your work and the time you put it in ! 🙏 |
|
Per this project policy, as we just merged a significant work on colored, you are granted the title of contributor and committer ! Congrats ! 🎊 🎉 Now, you have the authority to review and merge PRs of other contributors. :) Obviously, you don't have to do anything more than before. It's not an obligation and you can carry on your life as before. Please don't see it as an obligation but rather as a new possibility, if and only if you want to push this crate forward. No pressure. 🙏 |
I've listed the details of each fix into its own commit message
Warnings were found by running
cargo clippyand
cargo testrust version 1.43.0
@kurtlawrence