Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont assume the post-body is json #5

Open
FrankyBoy opened this issue Oct 10, 2014 · 1 comment
Open

Dont assume the post-body is json #5

FrankyBoy opened this issue Oct 10, 2014 · 1 comment

Comments

@FrankyBoy
Copy link

Hi!
Right now the assumption is that the value provided to .post is json, which is quite bad.
Two ways of fixing this: add an "if", or just let the user set the right property in the "options" object themselves.
@FrankyBoy
Copy link
Author

Commit for this: FrankyBoy@b2353fb ... for some reason it seems commits dont get linked if they are pushed before the defect report ;)

apasquale pushed a commit to apasquale/request-ntlm that referenced this issue Jun 23, 2016
@FrankyBoy
fixes colynb#5 ... don't assume everything is json
b2353fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FrankyBoy