Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scala 2.13 compiler settings test #1516

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

carlosrogue
Copy link
Contributor

@carlosrogue carlosrogue commented Jul 4, 2024

Enable settings tests for any 2.12 versions.

This is a follow up of this conversation #1484 (review) I had previously with @lefou.

Tested with mill -i -w 'amm.repl[{2.12.19,2.13.14,3.4.2}].test.testOnly' -- 'ammonite.session.BuiltinTests.settings' so all 2.12, 2.13 and 3 latest versions are passing.

Enable settings tests for any 2.12 versions.
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for this follow up test improvement.

@lefou lefou merged commit 23a07fd into com-lihaoyi:main Jul 17, 2024
38 checks passed
@lefou lefou added this to the 3.0.0-M3 milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants