Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated universal script and removed shebang line by default #789

Merged
merged 7 commits into from
Mar 31, 2018
Merged

Conversation

lhns
Copy link

@lhns lhns commented Mar 30, 2018

This pr changes updates the generated universal script to be on par with com-lihaoyi/mill#264.
Also the shebang line isn't generated anymore by default so that it doesn't show an error on windows anymore.
The linux download instructions should be updated to add this line afterwards.

@robby-phd
Copy link
Collaborator

Nice, thanks. Do you want to propose the change to the curl+chmod command here and here (need a separate unstableCurlCommand for now); perhaps throw in some Windows instructions for good measure (e.g., a simple url direct link with a brief "save as amm.bat" instruction would suffice).

@lhns
Copy link
Author

lhns commented Mar 31, 2018

What do you think about this?
sudo sh -c '(echo "#!/usr/bin/env sh" && curl -L $curlUrl) > /usr/local/bin/amm && chmod +x /usr/local/bin/amm' && amm

@robby-phd
Copy link
Collaborator

That works.

@lhns
Copy link
Author

lhns commented Mar 31, 2018

Okay I added this to the docs as well as the info for windows. Sadly I was not able to figure out how to generate the page to test out if it looks right since I have never worked with scalatex before.
I already tried running sbt "readme/run" but it only seems to generate the api docs.

@robby-phd
Copy link
Collaborator

You can run amm ci/build.sc docs to compile the readme (it does not replace the curl url, however).

Anyway, this looks good to me. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants