Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Scala-Native 0.5.0, bump minimum versions of Scala 2 and Scala 3 accordingly #73

Merged
merged 2 commits into from
Apr 14, 2024

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Apr 14, 2024

This would be the first step in getting the rest of com.lihaoyi out for scala native 0.5.0

Given the version support drops, which version should we bump here? Would it be the major version (i.e. geny 2.0.0), or a minor version (i.e. geny 1.1.0)? I am inclined to make it a minor version, reflecting the fact that Scala 3.1.3 is not LTS so dropping support is not a huge deal

@lihaoyi lihaoyi requested review from lefou and lolgab April 14, 2024 03:48
@lihaoyi
Copy link
Member Author

lihaoyi commented Apr 14, 2024

review by @lolgab @lefou

@lolgab
Copy link
Member

lolgab commented Apr 14, 2024

There is consensus among the Scala Native to not crosscompile but just switch to the new Scala Native version.
Regarding the version, since Scala Native is an experimental target, I would increase the patch version or at most the minor, increasing the major is disruptive the whole ecosystem for no reason since switching native version we are releasing a completely new artifact and stop releasing another one, but the other artifacts are fully compatible with each other

@lefou
Copy link
Member

lefou commented Apr 14, 2024

I think a minor version bump is fine.

@lihaoyi
Copy link
Member Author

lihaoyi commented Apr 14, 2024

Ok, I'll merge this and release it as 1.1.0 then

@lihaoyi lihaoyi merged commit 43d4238 into main Apr 14, 2024
3 of 4 checks passed
@lolgab lolgab deleted the native0.5 branch April 14, 2024 12:35
@lefou lefou added this to the after 1.0.0 milestone Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants