Skip to content

Commit

Permalink
Default KtlintModule to .editorconfig explicitly (#3966)
Browse files Browse the repository at this point in the history
For some reason `ktlint` behaves differently if it's config is set vs
unset to it's default of `.editorconfig`.

It seems to be unable to disable `ktlint` when not explicitly set, so I
think we should set it instead.

Why not bump the version while we're at it?

---------

Co-authored-by: Li Haoyi <haoyi.sg@gmail.com>
  • Loading branch information
myyk and lihaoyi authored Nov 14, 2024
1 parent b34476e commit 231ff64
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions kotlinlib/src/mill/kotlinlib/ktlint/KtlintModule.scala
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ trait KtlintModule extends JavaModule {
* Ktlint configuration file.
*/
def ktlintConfig: T[Option[PathRef]] = Task {
None
Some(PathRef(Task.workspace / ".editorconfig"))
}

/**
* Ktlint version.
*/
def ktlintVersion: T[String] = Task {
"1.3.1"
"1.4.1"
}

/**
Expand Down

0 comments on commit 231ff64

Please sign in to comment.