Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Scala.js linker config OutputPatterns #1721

Closed
shishkin opened this issue Jan 30, 2022 · 1 comment · Fixed by #2233
Closed

Support Scala.js linker config OutputPatterns #1721

shishkin opened this issue Jan 30, 2022 · 1 comment · Fixed by #2233
Milestone

Comments

@shishkin
Copy link
Contributor

In order to be able to run ESModules on Node without tinkering with package.json, linker output needs to have .mjs extension instead of .js. Scala.js linker supports this via OutputPatterns. Mill ScalaJSModule doesn't expose that config in its API.

Also, would it make sense to expose Scala.js linker API directly instead of the current facade API?

@lolgab
Copy link
Member

lolgab commented Apr 27, 2022

Also, would it make sense to expose Scala.js linker API directly instead of the current facade API?

This is not possible because we need to support multiple versions of Scala.js and by depending on it directly you lose this property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants