Add support for scalaJSOutputPatterns #2233
Conversation
| private[scalajslib] val jsFile: String, | ||
| private[scalajslib] val sourceMapFile: String, | ||
| private[scalajslib] val moduleName: String, | ||
| private[scalajslib] val jsFileURI: String, | ||
| private[scalajslib] val sourceMapURI: String |
There was a problem hiding this comment.
As the apply and the withX methods are public, there is no reason to keep these vals non-public.
There was a problem hiding this comment.
Inspired by Scala.js. This configuration class is meant to be a "write-only", there is no usage on the reading side, that's why I think they make the values package-private here.
There was a problem hiding this comment.
The apply is private as well
There was a problem hiding this comment.
I just noticed the apply is private, too. Still, I think, if we can create it with some method e.g. withJSFile accepting a String, than there is sooner or later someone who will want to programmatically retrieve that String, e.g. to manipulate it slightly.
If there is no other good reason (as we don't protect use from extra API maintenance here), we should not make it harder than necessary and make it public.
There was a problem hiding this comment.
Usually, I prefer to follow whatever the Scala.js plugin does, but what you said makes sense.
Made them public ✅
| moduleSplitStyle: ModuleSplitStyle, // ignored in 0.6 | ||
| outputPatterns: OutputPatterns // ignored in 0.6 |
There was a problem hiding this comment.
It makes sense to focus on dropping 0.6 support at this point. See #2218.
There was a problem hiding this comment.
Yes, this is meant to go very soon, so we don't want to invest time on it :)
Fixes #1721