-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash in IntelliJ BSP import #2484
Comments
Here is the bsp file contents that IntelliJ is using: {"name":"mill-bsp","argv":["/home/naftoli/bin/mill","--bsp","--disable-ticker","--color","false","--jobs","1", "--debug"],"millVersion":"0.10.12","bspVersion":"2.0.0","languages":["scala","java"]} |
I don't know why scalacOptions has to run
|
Wait, so then I did another import and checked the last occurence in the logs and it was the same error on a different module (selenium_tests.test.compile), and when I invoked that manually it succeeded, and then I ran import again, and it worked! |
Could be also IJ, which is in heavy refactoring regarding BSP. What version do you use? Could you cross-check how Metals behaves, e.g. with vscode? You can also inspect |
It wasn't generating the stderr file. But this is what intellij says mill actually returned in its response to intellij. |
That can't be right. If there is no |
I don't remember the exact sequence of events. It was a few days ago, and even after the workaround I described Ctrl-F9 was using the IDEA builder, and it was tedious to do the workaround every time I reimported, so I went back to sbt. So my memory is a little hazy. However, there sometimes were those files but maybe I had to add https://gist.github.com/nafg/9ed02e141f5f70ecacadffeb1c9b0f43 |
Also note that the stack trace shows that it's happening in Mill. |
Is there a simple way to test the BSP response with |
If you start Mill with the |
For further analysis, it might be helpful to provide your |
Hi, sorry for not responding earlier -- I had to switch back to sbt and have been very busy. Here are the relevant build files: https://gist.github.com/nafg/8bf78893a54fa8ead7d61586cd499880 |
I'm happy to provide full project access privately if you like |
Hi! This is my first contribution, so please let me know if there is anything for me to do. As far as I understand this is OK, since `bspCompileClasspath` mentions it tries not to trigger compilation, so the transitive version may also try not to trigger compilation of the module dependencies. This would be helpful to us, since we currently cannot load projects in intellij via bsp if there is a compilation error in any module other than the topmost module. On the surface this seems similar to the issue in #2484 (failing on `buildTarget/scalacOptions` due to an error within `_.compile`). Pull request: #2646
Going to call this hopefully fixed by @alexarchambault 's work adding a coarse grained lock around the out folder |
I get this in the Build tool window in the Sync tab:
I found IntelliJ's BSP trace logs, which includes the response object. It looks like this:
It was a long string with a lot of
\n
s in it. I unescaped it to make it legible:The text was updated successfully, but these errors were encountered: