Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--import doesn't work anymore #2485

Closed
lolgab opened this issue Apr 30, 2023 · 0 comments · Fixed by #2502
Closed

--import doesn't work anymore #2485

lolgab opened this issue Apr 30, 2023 · 0 comments · Fixed by #2502
Milestone

Comments

@lolgab
Copy link
Member

lolgab commented Apr 30, 2023

mill --import ivy:com.lihaoyi::mill-contrib-bloop:0.11.0-M8  mill.contrib.bloop.Bloop/install

doesn't add the contrib module in Mill 0.11.0-M8

lihaoyi added a commit that referenced this issue May 5, 2023
Fixes #2485

We take the `config.imports` field and pass it to
`MillIvy.processMillIvyDepSignature` inside `ivyDeps`. This was
overlooked in #2377, but seems
easy enough to put back

Honestly not super sure how to test this. But when I run

```
./mill -i dev.run example/tasks/3-anonymous-tasks -i --import ivy:com.lihaoyi::mill-contrib-bloop:0.11.0-M8  mill.contrib.bloop.Bloop/install
```

On main branch, I get 

```
Cannot resolve external module mill.contrib.bloop.Bloop
```

On this PR I get

```
java.lang.NoSuchMethodError: 'java.lang.ThreadLocal mill.eval.Evaluator$.currentEvaluator()'
    mill.contrib.bloop.Bloop$$anonfun$$lessinit$greater$1.apply(Bloop.scala:8)
    mill.contrib.bloop.Bloop$$anonfun$$lessinit$greater$1.apply(Bloop.scala:8)
```

Seems like there's a binary incompatibility, but at least the `--import`
flag took effect?
@lefou lefou added this to the 0.11.0-M9 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants