Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shade / Relocation of classes support #355

Closed
saikocat opened this issue May 30, 2018 · 5 comments · Fixed by #947
Closed

Shade / Relocation of classes support #355

saikocat opened this issue May 30, 2018 · 5 comments · Fixed by #947
Milestone
0.9.3

Comments

@saikocat
Copy link

I couldn't find any docs nor part of the source code to do this. Any chance for a write-up or wiki on this? Built-in JarJar support for assembly would be nice! Much appreciated! Thanks for an amazing build tool.
@lihaoyi
Copy link
Member

lihaoyi commented Dec 15, 2018

closing due to inactivity

@lihaoyi lihaoyi closed this as completed Dec 15, 2018
@lefou lefou added the invalid This issue is invalid or lacks required information label May 20, 2019
@nvander1
Copy link
Contributor

I know of others that would very much appreciate this feature (myself included). @lefou, @lihaoyi Is this marked wontfix only due to inactivity, or are there design decisions not to allow this? I'd be happy to attempt it if no one else wants to.

@Ammonite-Bot
Copy link
Collaborator

Ammonite-Bot commented May 31, 2019 via email

@lefou
Copy link
Member

lefou commented Jun 3, 2019

@nvander1 I was going through old issues and pull requests and tagged them with milestone versions or labels to better indicate if implemented or not. Feel free to work on it.

@lefou lefou reopened this Jun 3, 2019
@lefou lefou removed the invalid This issue is invalid or lacks required information label Jun 3, 2019
@joan38
Copy link
Collaborator

joan38 commented Aug 12, 2020

I'm looking for this feature!

@joan38 joan38 mentioned this issue Aug 13, 2020
Merged
lefou pushed a commit that referenced this issue Aug 27, 2020
@joan38
Ability to relocate/shade in assembly (#947)
1a410f0 
This gives the ability to relocate/shade in assembly on a global level.
This is a good first step but we might want later to provide the ability to shade only for a given lib. This is currently not possible because at the time we get the class path we lost the information of the dependency tree.

Resolves #355

Example of usage:

  override def assemblyRules =
    Assembly.defaultRules ++ Seq(Assembly.Rule.Relocate("shapeless.**", "com.netflix.data.playback.shade.shapless.@1"))

Pull request: #947
@lefou lefou added this to the after 0.8.0 milestone Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.3
Development

Successfully merging a pull request may close this issue.

Ability to relocate/shade in assembly joan38/mill
6 participants
@lihaoyi @joan38 @lefou @saikocat @nvander1 @Ammonite-Bot