Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mill.scalalib.GenIdea/idea does not download Mill's source jars or reference them in .idea*/* files #533

Closed
steven-collins-omega opened this issue Jan 25, 2019 · 1 comment
Labels
duplicate The issue is a duplicate of another one. Progress is tracked in another issue.

Comments

@steven-collins-omega
Copy link

steven-collins-omega commented Jan 25, 2019

This was discussed briefly in the Gitter channel on 23-25 Jan 2019.

One of the “selling” points of Mill is useful “Jump to Definition”. In fact, though (as stated in the title of this issue), the generated IntelliJ project does not reference or have local access to Mill's source jars.

It's tricky to test this because when you build and publish Mill locally, it publishes its source jars and then IntelliJ can find them. (Thus, building from source is a workaround for the problem.) The best I could come up with in my attempts to fix/troubleshoot this was to delete those source jars manually after publishing but before running for the first time. Also, a Mill custom-built from a local commit is going to have a version number different from anything on Maven, so pulling source jars will definitely fail anyway. I tried to get around that by setting the JVM prop MILL_VERSION to the latest version on Maven, but I don't know if that has other consequences for Mill's correct functioning.

I naively tried just changing https://github.com/lihaoyi/mill/blob/master/scalalib/src/GenIdeaImpl.scala#L83 from false to true (same caveat as above on setting MILL_VERSION), which did fetch the source jars from Maven, but also had the side effect that it didn’t put any information whatsoever about any of Mill’s dependencies in the .idea*/* files.

@steven-collins-omega
Copy link
Author

Duplicate of #527

@lefou lefou added the duplicate The issue is a duplicate of another one. Progress is tracked in another issue. label Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate The issue is a duplicate of another one. Progress is tracked in another issue.
Projects
None yet
Development

No branches or pull requests

2 participants