Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenIdea not downloading mill sources (but resolving them if already downloaded) #708

Closed
guilgaly opened this issue Oct 11, 2019 · 4 comments
Milestone

Comments

@guilgaly
Copy link
Contributor

When I execute the GenIdea task, the source JARs for mill itself (e.g. mill-scalalib_2.12-0.5.1-sources.jar) are not dowloaded and don't appear in the mill-build module in IntelliJ. For instance, I get this:

<component name="libraryTable">
  <library name="mill-scalalib_2.12-0.5.1.jar">
    <CLASSES>
      <root url="jar://$USER_HOME$/.coursier/cache/v1/https/repo1.maven.org/maven2/com/lihaoyi/mill-scalalib_2.12/0.5.1/mill-scalalib_2.12-0.5.1.jar!/" />
    </CLASSES>
    <JAVADOC />
    <SOURCES />
  </library>
</component>

However, if those source JARs are already present in ~/.coursier/cache (because I downloaded them manually), then GenIdea does correctly add them to the mill-build module. For instance, I get this:

<component name="libraryTable">
    <library name="mill-scalalib_2.12-0.5.1.jar">
        <CLASSES>
            <root url="jar:///Users/guillaumegaly/.coursier/cache/v1/https/repo1.maven.org/maven2/com/lihaoyi/mill-scalalib_2.12/0.5.1/mill-scalalib_2.12-0.5.1.jar!/"/>
        </CLASSES>
        <SOURCES>
            <root url="jar:///Users/guillaumegaly/.coursier/cache/v1/https/repo1.maven.org/maven2/com/lihaoyi/mill-scalalib_2.12/0.5.1/mill-scalalib_2.12-0.5.1-sources.jar!/"/>
        </SOURCES>
    </library>
</component>

There already was a similar issue, now closed: #533 (duplicate of #527). It now seems to be partially working though, so probably a bit different ?

@guilgaly
Copy link
Contributor Author

If it can help, I can try to investigate this when I have the time, possibly later this month.

@htmldoug
Copy link

coursier fetch --sources com.lihaoyi:mill-scalalib_2.12:0.5.1

Thanks for the workaround hint. I'd love if mill did this itself, or had an option to.

@lefou
Copy link
Member

lefou commented Oct 22, 2019

Can you try if #719 fixes it?

lefou added a commit to lefou/mill that referenced this issue Oct 23, 2019
lefou added a commit that referenced this issue Oct 24, 2019
@lefou
Copy link
Member

lefou commented Oct 24, 2019

Fixed by #719

@lefou lefou closed this as completed Oct 24, 2019
@lefou lefou added this to the after 0.5.2 milestone Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants