PathRef.sig is now independent of the base path
#2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
force-pushed
the
pathref-independend-sig
branch
from
7d27f06
to
ccf28a5
Compare
lefou
force-pushed
the
pathref-independend-sig
branch
from
ccf28a5
to
c0c2b43
Compare
lefou
force-pushed
the
pathref-independend-sig
branch
from
c0c2b43
to
d3dbf6c
Compare
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That means, the exact same sub-directory tree should have the same
sig, butPathRef.hashCodeis still different, as it contains a different path.This makes
sigmore stable, which might improve special use cases like caching whiledocker build. I've not validated that, though.While implementing the tests, I noticed, that there is still some (stable) differences in
sigbetween Windows and Unix-bases OSs.