Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mill._ magic import from builds #2418

Merged
merged 10 commits into from
Jun 7, 2023

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Apr 5, 2023

Follow up to discussion in #2381

@lolgab lolgab force-pushed the remove-magic-mill-import branch from 93a86f6 to 3f7950c Compare April 11, 2023 15:41
@lolgab
Copy link
Member Author

lolgab commented Jun 6, 2023

MillBuildRootModule was also imported via a magic import.
Should we require users to import mill.runner._ or should we add a type alias in the package object mill?

@lihaoyi
Copy link
Member

lihaoyi commented Jun 6, 2023

Requiring a mill.runner._ import is probably not what we want, from a user perspective

The reason we need a separate import is because the mill._ import is in main, but mill.runner.MillBuildRootModule is in runner

I think we don't need to fix that right now. It's definitely a bit awkward, but it's not causing any user-facing issues, so we can take our time and fix it next binary incompatible release

@lihaoyi lihaoyi marked this pull request as ready for review June 7, 2023 05:03
Co-authored-by: Tobias Roeser <le.petit.fou@web.de>
@lihaoyi lihaoyi merged commit 327d1b8 into com-lihaoyi:main Jun 7, 2023
@lefou lefou added this to the 0.11.0 milestone Jun 7, 2023
@lolgab lolgab deleted the remove-magic-mill-import branch June 7, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants