Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put BSP timing tests behind a retry, as these fail sometimes on Windows #2490

Merged
merged 1 commit into from
May 2, 2023
Merged

Put BSP timing tests behind a retry, as these fail sometimes on Windows #2490

merged 1 commit into from
May 2, 2023

Conversation

lefou
Copy link
Member

@lefou lefou commented May 2, 2023

No description provided.

lihaoyi
lihaoyi approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@lihaoyi lihaoyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed windows CI performance is realy variable. The integration.feature.__.local tests take anywhere from 30-90min to run, huge amount of variation

@lefou lefou merged commit 14e1615 into main May 2, 2023
@lefou lefou deleted the retry-timing-tests branch May 2, 2023 11:45
@lefou lefou added this to the 0.11.0-M9 milestone May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihaoyi lihaoyi lihaoyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0-M9
Development

Successfully merging this pull request may close these issues.
2 participants
@lefou @lihaoyi