Make mill-build folder opt in via import $meta._
#2527
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2461
For now it remains hard-coded as
mill-build/
, for simplicity. Given themill-
prefix, it's unlikely to collide with user-defined folders. Making it configurable would open another can of worms where theimport $meta.foo
can now collide with anobject foo
, which is very unintuitive.For now, we just parse the script files one additional time in
MillBuildBootstrap.scala
. This is a bit wasteful, but is probably fast enough for now, and we're already pretty sloppy parsing everything twice inMillBuildRootModule#scriptSources
andMillBuildRootModule#parseBuildFiles
, so parsing things three times isn't the end of the world. We can look into optimizing it in future if necessary