Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use project root as T.workspace also in meta-build #2809

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Use project root as T.workspace also in meta-build #2809

merged 2 commits into from
Oct 2, 2023

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Oct 2, 2023 •
edited by lefou
Loading

Fixes #2802

Pull request: #2809

@lolgab lolgab marked this pull request as ready for review October 2, 2023 12:00
@lolgab lolgab requested review from lihaoyi and lefou October 2, 2023 12:17
lefou
lefou approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lolgab lolgab merged commit 1a7e758 into com-lihaoyi:main Oct 2, 2023
37 checks passed
@lolgab lolgab deleted the projectRoot-workspace branch October 2, 2023 22:42
@lefou lefou added this to the 0.11.5 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

@lihaoyi lihaoyi Awaiting requested review from lihaoyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.5
Development

Successfully merging this pull request may close these issues.

semanticDbData fails on --meta-level 1
2 participants
@lolgab @lefou