Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Errors not cleaning up in BSP for Scala 3 #2810

Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix: Errors not cleaning up in BSP for Scala 3 #2810

merged 1 commit into from
Oct 2, 2023

Commits on Oct 2, 2023

  1. fix: Errors not cleaning up in BSP for Scala 3 

    The Scala 3 compiler is not calling `startUnit` as the Scala 2 compiler.
I checked what sbt is doing and it sends a build/publishDiagnostics
for all the compiled files at the end of compilation.
So I'm doing the same here.
I removed the `CompileProgress` and I'm calling fileVisited for all
input files instead.
I tried to not touch the `CompileProblemReporter` trait for now since
it's public API and I don't want to deal with the binary compatibility
issues. Moreover, our current `fileVisited` API seems more than enough
    @lolgab
    lolgab committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    71a606f View commit details
    Browse the repository at this point in the history