Apply coursier default config files (repositories and mirrors config)

[jilen]

Fix #2312

Copied from
https://github.com/coursier/coursier/blob/main/modules/coursier/shared/src/main/scala/coursier/Resolve.scala#L61

It is possible to use Resolve().finalRepositories.future() to avoid the implementation detail.

But that requires Await and ExecutionContext, I'm not sure whether worth doing it.

[lefou]

I'd favor just calling the configuration logic from coursier. Copied code will get out of sync eventually. Await is standard Scala, so it should be fine to use it. It's easy to identify as boilerplate when reviewing the code.

[jilen]

@lefou Now it is implemented using finalRepositories .

[lefou]

Yeah, that's better.
We can import the execution context more local, e.g. just in the task.
Beside that, it looks good to me.

How did you test this? Would it be possible to add a small integration test under integration.feature or example.misc?

[jilen]

Yeah, that's better. We can import the execution context more local, e.g. just in the task. Beside that, it looks good to me.

How did you test this? Would it be possible to add a small integration test under integration.feature or example.misc?

I test it by remove repo1.maven.org in the coursier cache directory. And it won't appear again.
I'll try to add some test

[lefou]

In an integration test, we could use a different empty temporary cache location and could either assert, that Mill fails as expected, or fills that repo as expected.

[jilen]

@lefou I've add a test suite by setting the courser.mirrors system property.

[lefou]

Looks good to me. Thanks for adding a test!

[lefou]

Thank you for this contribution, @jilen !

[lefou]

This is available in 0.11.6-10-452bf6.

[lefou]

@jilen It would be really cool, if you could review our documentation regarding repository configuration. We should mention all potential ways to customize it. IIUC, we now also support some coursiers-specific config files.