Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zinc from 1.9.6 to 1.10.0, use improved analysis store #2899

Merged
merged 11 commits into from
May 6, 2024

Conversation

lefou
Copy link
Member

@lefou lefou commented Nov 27, 2023

This PR updates Zinc to 1.10.0. We make use of a new ConsistentFileAnalysisStore which is used by zinc to store internal analysis data used for incremental compilation. The new store is faster and more reproducible.

@lefou lefou changed the title [POC] Update zinc to 1.10.0-M1 [POC] Update zinc to 1.10.0-M2 Dec 7, 2023
@lefou lefou changed the title [POC] Update zinc to 1.10.0-M2 [POC] Update zinc to 1.10.0-M3 Feb 24, 2024
@lefou lefou force-pushed the poc-update-zinc branch 2 times, most recently from 3c91d22 to b9295b1 Compare April 11, 2024 07:05
@lefou lefou changed the title [POC] Update zinc to 1.10.0-M3 [POC] Update zinc to 1.10.0-RC1 Apr 11, 2024
@jilen
Copy link
Contributor

jilen commented Apr 26, 2024

A new ConsistentFileAnalysisStore introduced to improve serialization performance.
It will become default in next sbt version.
Maybe mill can switch to it.

@lefou lefou force-pushed the poc-update-zinc branch from b9295b1 to 8bfde57 Compare April 26, 2024 05:36
@lefou
Copy link
Member Author

lefou commented Apr 26, 2024

@lefou lefou changed the title [POC] Update zinc to 1.10.0-RC1 [POC] Update zinc to 1.10.0-RC2 Apr 26, 2024
This is some arbitrarily chooses value.
@lefou
Copy link
Member Author

lefou commented Apr 26, 2024

A new ConsistentFileAnalysisStore introduced to improve serialization performance. It will become default in next sbt version. Maybe mill can switch to it.

Done.

@lefou lefou changed the title [POC] Update zinc to 1.10.0-RC2 Update zinc to 1.10.0 and use improved analysis store May 6, 2024
@lefou lefou marked this pull request as ready for review May 6, 2024 06:37
@lefou lefou changed the title Update zinc to 1.10.0 and use improved analysis store Update zinc from 1.9.6 to 1.10.0, use improved analysis store May 6, 2024
@lefou lefou merged commit aa33565 into main May 6, 2024
38 checks passed
@lefou lefou deleted the poc-update-zinc branch May 6, 2024 09:26
@lefou lefou added this to the 0.11.8 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants