Fix the warning not being printed when -i/--interactive/--no-server/--bsp are not the first argument #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-bsp are not the first argument
|
Thanks @mkwpz! Email me your bank transfer details to haoyi.sg@gmail.com and I'll close out the bounty |
|
@lihaoyi I've sent you an email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug stems from the fact that a
PipedInputStreamis passed toMillMain.main0whereDummyInputStreamused to be. This PR fixes the bug by using aPipedInputStreaminstead of aDummyInputStreamon the check that leads to the warning being printed.Fixes #2869.