Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Checkstyle plugin #3472

Closed
wants to merge 31 commits into from
Closed

Add Checkstyle plugin #3472

wants to merge 31 commits into from

Commits on Sep 6, 2024

  1. Add dependency

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    4511ca5 View commit details
    Browse the repository at this point in the history

  2. Crib the basic parts of config from the error prone module

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ad009ae View commit details
    Browse the repository at this point in the history

  3. Start adapting the idea

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9c97b76 View commit details
    Browse the repository at this point in the history

  4. Put the classpath stuff back in

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    a2e1af5 View commit details
    Browse the repository at this point in the history

  5. Progress

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    b41b468 View commit details
    Browse the repository at this point in the history

  6. At the point where it actually compiles

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0029133 View commit details
    Browse the repository at this point in the history

  7. pickle shuffles

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    063cbd5 View commit details
    Browse the repository at this point in the history

  8. Add picklers for the others too

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9408db6 View commit details
    Browse the repository at this point in the history

  9. Sort out argument passing a bit

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c431142 View commit details
    Browse the repository at this point in the history

  10. Might work?

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3aa20d6 View commit details
    Browse the repository at this point in the history

  11. Fix up a little more

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    95b54c8 View commit details
    Browse the repository at this point in the history

  12. Progress towards testing

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0ca41aa View commit details
    Browse the repository at this point in the history

  13. Almost there

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c857d96 View commit details
    Browse the repository at this point in the history

  14. Now just need to fail the build

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0f28054 View commit details
    Browse the repository at this point in the history

  15. Add testing config

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    18b950e View commit details
    Browse the repository at this point in the history

  16. Apparently we just use an exception

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c221d31 View commit details
    Browse the repository at this point in the history

  17. Update config etc

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    dba12a2 View commit details
    Browse the repository at this point in the history

  18. Confirm that loading config from the classpath works

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    184b37d View commit details
    Browse the repository at this point in the history

  19. working on a test

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    79519f0 View commit details
    Browse the repository at this point in the history

  20. Test almost there

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f1a062f View commit details
    Browse the repository at this point in the history

  21. Test fully working

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    786a5b2 View commit details
    Browse the repository at this point in the history

  22. Run scalafix

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    2b47db1 View commit details
    Browse the repository at this point in the history

  23. Be more explicit about where the default config is

    @m50d
    m50d committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5048bbf View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Merge remote-tracking branch 'upstream/main' into checkstyle

    @m50d
    m50d committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    981cf06 View commit details
    Browse the repository at this point in the history

  2. Don't use the io api here

    @m50d
    m50d committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ea7d423 View commit details
    Browse the repository at this point in the history

  3. Remove optional wrapping here

    @m50d
    m50d committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c307bfc View commit details
    Browse the repository at this point in the history

  4. Move test to correct place

    @m50d
    m50d committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    348852e View commit details
    Browse the repository at this point in the history

  5. Add a formatting test that we can fix

    @m50d
    m50d committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b8656b5 View commit details
    Browse the repository at this point in the history

  6. Fix warnings

    @m50d
    m50d committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    fc6b557 View commit details
    Browse the repository at this point in the history

  7. Confirm that we can fix the violation and then have it pass

    @m50d
    m50d committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    7a55dd5 View commit details
    Browse the repository at this point in the history

  8. Run scalafmt

    @m50d
    m50d committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c9b14de View commit details
    Browse the repository at this point in the history