Add some BSP integration tests #3608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
force-pushed
the
bsp-integration-tests
branch
2 times, most recently
from
6892849 to
1d70b17
Compare
alexarchambault
force-pushed
the
bsp-integration-tests
branch
4 times, most recently
from
51659a8 to
4fae5d5
Compare
alexarchambault
force-pushed
the
bsp-integration-tests
branch
4 times, most recently
from
0f28cf2 to
59d99a8
Compare
This was referenced Oct 1, 2024
|
Not sure the CI error is related to my changes |
|
It's the flakiness that should be fixed by #3642 |
alexarchambault
force-pushed
the
bsp-integration-tests
branch
2 times, most recently
from
9abd3b7 to
8c959eb
Compare
|
Don't fear the apparent large diff, it's a lot of test fixtures. And most commits are kind of small. |
lefou
reviewed
Oct 1, 2024
lihaoyi
reviewed
Oct 2, 2024
lihaoyi
reviewed
Oct 2, 2024
lihaoyi
reviewed
Oct 2, 2024
lihaoyi
reviewed
Oct 2, 2024
lihaoyi
reviewed
Oct 2, 2024
| os.Path(value) | ||
| } | ||
|
|
||
| def replaceAllValues( |
There was a problem hiding this comment.
This name is kind of generic and hard to figure out. How about normalizePathsForTesting?
There was a problem hiding this comment.
It's not only paths, it's paths and Java version. I renamed it to normalizeLocalValuesForTesting in the latest push.
lihaoyi
reviewed
Oct 2, 2024
lihaoyi
reviewed
Oct 2, 2024
lihaoyi
reviewed
Oct 2, 2024
lihaoyi
reviewed
Oct 2, 2024
lihaoyi
reviewed
Oct 2, 2024
|
(If the CI is green, feel free to review, and possibly un-draft and merge) |
lihaoyi
reviewed
Oct 8, 2024
lihaoyi
reviewed
Oct 8, 2024
lihaoyi
reviewed
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some BSP integration tests, ensuring the Mill BSP server answers correctly basic BSP requests. BSP responses are serialized on disk and committed, and we compare the requests we get to those on disk. These fixtures on disk can be automatically generated and updated by changing a variable (currently,
BspServerUtil.updateFixtures), so that it's quite convenient to generate them, and update them and get a nice diff of the changes at the same time.