Standardize environment variables names on _DIR instead of _FOLDER
#3637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
lihaoyi
added a commit
that referenced
this pull request
Oct 1, 2024
* Swap from `ForkJoinPool` to `ThreadPoolExecutor`
* `ForkJoinPool` does this weird thing where fork-join-tasks can be
re-entrant at `join` points, resulting in weird scenarios where a
mill-task that hits a yield point (e.g. inside Zinc /
parallel-collections / FJP) can start running a second mill-task even
before the first has finished, violating all sorts of invariants (# of
running tasks exceeds `--jobs`, `FixSizeCache` semaphores get taken
twice by the same thread, all sorts of craziness)
* We replace `ForkJoinPool#ManagedBlocker` with our own manual logic
increasing and decreasing the `ThreadPoolExecutor`s `maximumPoolSize`
and `corePoolSize` in our `blocking{...}` wrapper
* We need to `Thread#interrupt()` the `promptUpdaterThread` thread when
we close the `PromptLogger`, so we don't need to wait the
`promptUpdateInterval` (0.1ms for interactive, 60s for non-interactive)
before exiting
This should fix some of the flakiness we've been seeing in master, that
seems to have started from
05bef7e
(just eyeballing the CI history), and blocking our re-bootstrapping in
#3637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows suit from #3530. This hasn't been released in a stable version yet so we are free to change it